Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Python 3.9 #1036

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Add support for Python 3.9 #1036

merged 4 commits into from
Jun 28, 2022

Conversation

lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Jun 14, 2022 •
edited
Loading

EDIT: there are some additional hurdles for 3.10, so let's focus on 3.9 in this PR

Summary

  • Support for Python versions 3.9 and 3.10 is important since 3.10 is now the default version in many environments including e.g. Conda

Changes proposed in this PR:

  • Update pylint version to better 3.9 and 3.10 support
  • Resolve pylint errors in current codebase by applying minor changes and disable pragmas
  • Add 3.9 and 3.10 to CI job matrixes and installation docs

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-assigned this Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.80%. Comparing base (08337e8) to head (0701c4f).
Report is 98 commits behind head on master.

Files Patch % Lines
foqus_lib/framework/graph/graph.py 0.00% 1 Missing ⚠️
foqus_lib/framework/uq/Model.py 50.00% 0 Missing and 1 partial ⚠️
foqus_lib/gui/model/dmfUploadDialog.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
+ Coverage   32.60%   32.80%   +0.20%     
==========================================
  Files         161      161              
  Lines       35950    35952       +2     
  Branches     6073     6073              
==========================================
+ Hits        11720    11794      +74     
+ Misses      23284    23219      -65     
+ Partials      946      939       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Jun 14, 2022
@lbianchi-lbl lbianchi-lbl mentioned this pull request Jun 14, 2022
Closed
@lbianchi-lbl
Copy link
Contributor Author

lbianchi-lbl commented Jun 21, 2022 •
edited
Loading

  • There's an error occurring for Python 3.10, which might be due to a compatibility issue in PyQt itself
  • According to this bug report for an unrelated tool that uses PyQt, there is a fix on the PyQt side, but that might not be included with the version (5.12.3) that we're using
  • We might want to check if the fix is in 5.15.X, in which case we'd have to decide whether we want to prioritize having support for Python 3.10 or Conda installation
    • See this comment for more information about the status of (Py)Qt 5.15 in Conda

@lbianchi-lbl lbianchi-lbl changed the title Add support for Python 3.9 and 3.10 Add support for Python 3.9 Jun 21, 2022
@lbianchi-lbl lbianchi-lbl requested a review from ksbeattie June 21, 2022 22:58
ksbeattie
ksbeattie approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit 5f7514e into CCSI-Toolset:master Jun 28, 2022
@lbianchi-lbl lbianchi-lbl mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie ksbeattie approved these changes

Assignees

@lbianchi-lbl lbianchi-lbl

Labels
Priority:High High Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbianchi-lbl @ksbeattie